tiradoe/movie-night-web
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request 'fixed loading loop when image not found' (#15) from image-loading-error-fix into main

Browse source 
Reviewed-on: #15
This commit is contained in:
Edward Tirado Jr 2026-04-21 04:48:33 +00:00
commit fdd3bc1f5a
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
app/components/movie-list.vue
View file

@ -75,9 +75,12 @@ const movieSearch = () => {
filteredMovies.value = sortMovies(filtered);
}
const handleImageError = (e: Event, movieId: number) => {
(e.target as HTMLImageElement).src = posterPlaceholder;
imageErrors.value.add(movieId);
const handleImageError = (_e: Event, movieId: number) => {
imageErrors.value = new Set(imageErrors.value).add(movieId);
}
const getPosterSrc = (movie: Movie) => {
return imageErrors.value.has(movie.id) ? posterPlaceholder : movie.poster;
}
const isSortActive = (field: SortField, direction: SortDirection): boolean => {
@ -130,7 +133,7 @@ const isSortActive = (field: SortField, direction: SortDirection): boolean => {
<div class="movie-poster-container">
<NuxtImg
:class="{ 'movie-poster-error': imageErrors.has(movie.id) }"
:src="movie.poster"
:src="getPosterSrc(movie)"
alt=""
class="movie-poster"
loading="lazy"